Repository navigation
deprecate diffpy.srfit.pdf in favor of diffpy.cmipdf - #237
Open
cadenmyers13 wants to merge 2 commits into
Open
cadenmyers13 wants to merge 2 commits into
cadenmyers13 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 51.64835% with 88 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
- Coverage 84.95% 84.21% -0.75%
==========================================
Files 44 46 +2
Lines 4886 5094 +208
==========================================
+ Hits 4151 4290 +139
- Misses 735 804 +69
|
Sorry, something went wrong.
Resolve conflict in pdf/basepdfgenerator.py by keeping the pdf-dep method renames and switching to the new structure_to_parameter_set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
Author
|
@sbillinge fixed the merge conflict. ready for review |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
btw, codecov here fails because all the PDF tests are skipped because we removed srreal as a dependency |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.