FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support Python 3.13, drop 3.10 by bobleesj · Pull Request #143 · diffpy/diffpy.srmise · GitHub

  1. diffpy
  2. diffpy.srmise

Repository navigation

Support Python 3.13, drop 3.10 - #143

Merged
sbillinge merged 6 commits into
diffpy:mainfrom
bobleesj:313
Oct 24, 2024
ConversationCommits (6)ChecksFiles changed
Merged

Support Python 3.13, drop 3.10#143
sbillinge merged 6 commits into
diffpy:mainfrom
bobleesj:313

Conversation

bobleesj commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

PLEASE READ FOR GITHUB MAINTAINERS:

If your package supports Python 3.10, 3.11, 3.12:

  • add requires-python = ">=3.10, <3.13"

If your package supports Python 3.11, 3.12, 3.13:

  • add requires-python = ">=3.11, <3.14"

For this PR reviewer:

Closes #144

conda create -n diffpy.srmise_env python=3.13
conda install --file requirements/conda.txt --file requirements/test.txt
pip install -e . --no-deps

Testing result:

No changes were needed.

bobleesj marked this pull request as ready for review October 24, 2024 18:45

bobleesj commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review

sbillinge reviewed Oct 24, 2024
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Talking to Tieqiong, we realize that in the toml file we want the line requires-python = ">=3.10" to be changed to 3.11 but also a <=3.13 (not sure the right syntax). In the future when conda-forge migrates to the next python version this will then fail with an unresolved error and not just break in the code.

This applies to all the packages so we need to let everyone know and have them update their packages this way.

bobleesj commented Oct 24, 2024
View reviewed changes

bobleesj left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@sbillinge ready for review - requires-python = ">=3.11, <=3.13" added

This was referenced Oct 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed

bobleesj commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

@sbillinge Added an news item for requires-python = ">=3.11, <=3.13", ready for review

bobleesj commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

@sbillinge Okay - >=3.11, <3.14 added. Just need to fix the issue titles

bobleesj commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

@sbillinge Updated the news file as provided in the general group channel. Ready for review

sbillinge merged commit c60c04a into diffpy:main Oct 24, 2024
bobleesj deleted the 313 branch October 25, 2024 00:05
bobleesj mentioned this pull request Oct 25, 2024
Closed
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update requires-python in pyproject.toml

2 participants

Back | FazBrowse Home | New Git URL