Repository navigation
modified code to use Q_broad_new attributes in libdiffpy peak widths - #22
Open
rjkoch wants to merge 1 commit into
Open
rjkoch wants to merge 1 commit into
rjkoch wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I suspect all checks will continue to fail until diffpy/libdiffpy#30 is merged in. The changes in this current PR rely on changes in the libdiffpy module. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This looks interesting to me. It would be good to look into refreshing this and merging it. I would rather not call it qbroad_new, so find a more descriptive name, but it would be good to implement this. Why not? |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the pdfcalculators to take advantage of the Q_broad_new parameters in the JeongPeakWidth of libdiffpy.
relates to
diffpy/libdiffpy#29
and
diffpy/libdiffpy#30
@pavoljuhas @sbillinge Ready for review