Repository navigation
fix: complete dependencies - #45
Merged
sbillinge merged 1 commit intoJan 11, 2025
Merged
sbillinge merged 1 commit into
sbillinge merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@Tieqiong can we have a quick chat about this? In general, we may want to think about how we want to handle this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I will merge this to continue the cookiecutting, but have made an issue to revisit after our discussions. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge This still needs some discussion.
objcryst support will not be activated if libdiffpy isn't complied with libobjcryst, but if libdiffpy is complied with libobjcryst then libobjcryst (and of course libdiffpy) will also be a build dependency of diffpy.srreal. pyobjcryst is also needed for diffpy.srreal (built with libobjcryst), which has weird conda install conflicts for me even if it's up to py3.13. It can be installed for py3.11.
periodictable is a pure python optional run dependency.