FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: move tests and fix pytest by Tieqiong · Pull Request #46 · diffpy/diffpy.srreal · GitHub

Repository navigation

refactor: move tests and fix pytest - #46

Merged
sbillinge merged 7 commits into
diffpy:cookiefrom
Tieqiong:test
Jan 11, 2025
Merged

sbillinge merged 7 commits into
diffpy:cookiefrom
Tieqiong:test

Conversation

Tieqiong commented Jan 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sbillinge please check, thanks

With periodictable installed and a libdiffpy compiled from the repository against objcryst:

Copy link
Copy Markdown
Contributor

I will merge this because it is a huge PR, but I am not sure we want all the infrastructure for helping tests pass when different packages are missing. The point of tests is to fail when things are not right, and when dependencies are not available, things are not right, unless we decide that this is desirable behavior. @Tieqiong @bobleesj, can we meet and make a plan for this? I will open an issue to revisit this.

S

sbillinge merged commit 5f34e62 into diffpy:cookie Jan 11, 2025

Copy link
Copy Markdown

@sbillinge Yes, I can meet early next week, Monday morning? @Tieqiong

Copy link
Copy Markdown
Contributor

I am traveling Monday and won't be available. Please pick a time on my calendar from Tuesday onwards

Tieqiong commented Jan 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sbillinge @bobleesj How's tomorrow looking? I imagine this will be a quick one. I want to make sure there's enough time to release srreal before the 15th as well.

Copy link
Copy Markdown

I will be flying tmr (Sun). Mon works

Copy link
Copy Markdown
Contributor

I can't do Monday. @Tieqiong you and I can talk today if you are available. When would be a good time

Copy link
Copy Markdown
Contributor Author

@sbillinge Can we meet sometime in the afternoon, like after 3 pm?

Tieqiong deleted the test branch June 18, 2025 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL