FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skpkg: pre-commit auto fixes by cadenmyers13 · Pull Request #55 · diffpy/diffpy.srreal · GitHub

Repository navigation

skpkg: pre-commit auto fixes - #55

Merged
sbillinge merged 3 commits into
diffpy:cookiefrom
cadenmyers13:pre-commit-auto
Jun 20, 2025
Merged

sbillinge merged 3 commits into
diffpy:cookiefrom
cadenmyers13:pre-commit-auto

Conversation

cadenmyers13 commented Jun 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ran pre-commit and these are the autofixes from isort and flake8 line length. This will fail flake8 because of linelength. Ill do manual edits on another PR.

Copy link
Copy Markdown
Contributor Author

@Tieqiong I'm getting this failure. Do you know why?

Copy link
Copy Markdown
Contributor

@cadenmyers13 I don't have access so I can't make changes directly into this PR. Let's use Mac instead of Linux for now. Simply go to test-on-pr.yml, line 17 change

    runs-on: ubuntu-latest

to

    runs-on: macos-14

and tests should pass

Copy link
Copy Markdown
Contributor Author

@Tieqiong great, thanks!

sbillinge merged commit a1420e4 into diffpy:cookie Jun 20, 2025
cadenmyers13 deleted the pre-commit-auto branch June 23, 2025 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL