| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@sbillinge it says workflow needs approval...? |
Sorry, something went wrong.
|
@cadenmyers13 its failing tests. It looks like it needs the environment.yml file, but try and see. When you ran skpkg, did you select that it has c-code? if not, then we need to redo it. If yes, then we need to loop in @Tieqiong and @bobleesj to understand what is different here. |
Sorry, something went wrong.
|
actually, since you are mergint into cookie, it is possible that we need to merge main into cookie to get tests to pass. see if you can figure out how to get tests running locally, first on main and then on cookie. |
Sorry, something went wrong.
@sbillinge yes i did do that. I'll try to get test passing locally |
Sorry, something went wrong.
|
@sbillinge I configured the tests-on-pr.yml to run without the environment.yml file. I tested it on a PR on my fork and all the tests passed: cadenmyers13#1. This is my first time configuring the CI so please check that everything looks okay here. I put in some effort to understand whats actually happening so I'm fairly confident this isn't just "magic". |
Sorry, something went wrong.
There was a problem hiding this comment.
one quick comment left.
Sorry, something went wrong.
|
|
||
| .. _getting-started: | ||
|
|
||
| ================ |
There was a problem hiding this comment.
we may want to leave this here as a stub or remove it. If we leave it, the wording could change to something like "getting started information will appear here shortly" and make an issue to do it.
On the whole, it may be better to just delete it.
Sorry, something went wrong.
There was a problem hiding this comment.
@sbillinge yeah we can remove it. If we want to use the format later we can just pull it from skpkg.
Sorry, something went wrong.
|
@sbillinge Okay, i removed that file. should be good! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
After this, everything in srreal should be up to date! We can check it off the list.