FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skpkg: final skpkg migration of files by cadenmyers13 · Pull Request #58 · diffpy/diffpy.srreal · GitHub

Repository navigation

skpkg: final skpkg migration of files - #58

Merged
sbillinge merged 15 commits into
diffpy:cookiefrom
cadenmyers13:skpkg-migration
Jun 26, 2025
Merged

sbillinge merged 15 commits into
diffpy:cookiefrom
cadenmyers13:skpkg-migration

Conversation

Copy link
Copy Markdown
Contributor

After this, everything in srreal should be up to date! We can check it off the list.

Copy link
Copy Markdown
Contributor Author

@sbillinge it says workflow needs approval...?

Copy link
Copy Markdown
Contributor

@cadenmyers13 its failing tests. It looks like it needs the environment.yml file, but try and see. When you ran skpkg, did you select that it has c-code? if not, then we need to redo it. If yes, then we need to loop in @Tieqiong and @bobleesj to understand what is different here.

Copy link
Copy Markdown
Contributor

actually, since you are mergint into cookie, it is possible that we need to merge main into cookie to get tests to pass. see if you can figure out how to get tests running locally, first on main and then on cookie.

Copy link
Copy Markdown
Contributor Author

When you ran skpkg, did you select that it has c-code?

@sbillinge yes i did do that. I'll try to get test passing locally

Copy link
Copy Markdown
Contributor Author

@sbillinge I configured the tests-on-pr.yml to run without the environment.yml file. I tested it on a PR on my fork and all the tests passed: cadenmyers13#1. This is my first time configuring the CI so please check that everything looks okay here. I put in some effort to understand whats actually happening so I'm fairly confident this isn't just "magic".

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

one quick comment left.

Comment thread doc/source/getting-started.rst Outdated

.. _getting-started:

================

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

we may want to leave this here as a stub or remove it. If we leave it, the wording could change to something like "getting started information will appear here shortly" and make an issue to do it.

On the whole, it may be better to just delete it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@sbillinge yeah we can remove it. If we want to use the format later we can just pull it from skpkg.

Copy link
Copy Markdown
Contributor Author

@sbillinge Okay, i removed that file. should be good!

sbillinge merged commit 724018c into diffpy:cookie Jun 26, 2025
cadenmyers13 deleted the skpkg-migration branch June 26, 2025 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL