| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This is a very early port with only syntax checks performed. The pickle suite naming is left but underneath it is handled differently, the final ways of pickling depends on migration for rest of the files.
Sorry, something went wrong.
There was a problem hiding this comment.
There's an explicit behavior change (or enhancement?) in atomadapter_indexing that non-unit and negative-step slices are handled. We may need to test this on all of the packages to see if it breaks anything.
Sorry, something went wrong.
|
@sbillinge Now the syntax have been migrated and build and tests are passed. I'll keep marking the PR as draft since I found some of parts are not done elegantly, but we can start reviewing this. |
Sorry, something went wrong.
|
@SYMSCAE pleae can you, on a separate PR, do the updates of the pre-commit versions so we can get that passing also? I will start to look at this. @pavoljuhas if you have time, there is more c++ reviewing here. @ycexiao @danielsirakov, if you guys have time, please could you also take a look. This is the work to migrate from boost to nanobind |
Sorry, something went wrong.
I'm working on that, but the change of docformatter breaks some things. I'll open a new PR and bring the discussion over there. |
Sorry, something went wrong.
chore: updated pre-commit hook dependencies
|
I merged that PR so you can update main and merge it into this branch |
Sorry, something went wrong.
…nd BondCalculator
…nd libdiffpy_version
…ty and PDFBaseline
|
@SYMSCAE this PR seems to have force-pushes on it which we don't want. I wonder how much work it would be to do this over on a clean PR without the force pushes. As a general matter, please never force-push. This is bypassing all of git's protections which is dangerous and it usually means that some incorrect workflow is being pushed, again, with often unforeseeable downstream consequences. I know there is quite a bit of work here so let's discuss it, but I would be much more comfortable having the work on a clean and properly sequenced (pre-commit fixes ahead of code fixes for example) set of PRs. |
Sorry, something went wrong.
Sure, I can open a new pr and cleanup the commits. Could you please sync the migration-nano branch with main. |
Sorry, something went wrong.
|
PR closed due to #89 being merged. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR is the initial port that migrates the original Boost.Python bindings to nanobind as mentioned in diffpy/pyobjcryst#88, noticed future improvements will be mentioned in TODOs but will be addressed in future PRs.