Repository navigation
skpkg: scikit-package to the latest workflow standard - #97
sbillinge merged 4 commits into
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 27 27
Lines 3967 3967
=======================================
Hits 3916 3916
Misses 51 51
|
Sorry, something went wrong.
| @@ -17,11 +17,5 @@ jobs: | |||
| project: diffpy.srreal | |||
| c_extension: true | |||
| headless: false | |||
| run: | | |||
There was a problem hiding this comment.
we probably need this.
Sorry, something went wrong.
| @@ -1,5 +1,5 @@ | |||
| default_language_version: | |||
| python: python3 | |||
| python: python3.14 | |||
There was a problem hiding this comment.
I think this should be unchanged as python3
Sorry, something went wrong.
There was a problem hiding this comment.
Please remove this file as this wasn't used.
Sorry, something went wrong.
|
OK, have removed the setup.py and fixed everything @sbillinge has mentioned, see the latest commit and another review. |
Sorry, something went wrong.
|
LGTM. Not seeing anything obvious that breaks the code. |
Sorry, something went wrong.
@sbillinge @SYMSCAE ready to review. I'm not a C expert so need some review over whether the setup is right. Mostly automatically done by the update command, but for scikit-package update, it creates a setup.py that controls the extension of C code, but not sure whether we actually need this from the nanobind conversion perspective. If it does not need it, let me know and I would delete it in the next commit.