FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: use external libdiffpy by SYMSCAE · Pull Request #98 · diffpy/diffpy.srreal · GitHub

  1. diffpy
  2. diffpy.srreal

Repository navigation

chore: use external libdiffpy - #98

Open
SYMSCAE wants to merge 2 commits into
diffpy:mainfrom
SYMSCAE:external-libdiffpy
ConversationCommits (2)ChecksFiles changed
Open

chore: use external libdiffpy#98
SYMSCAE wants to merge 2 commits into
diffpy:mainfrom
SYMSCAE:external-libdiffpy

Conversation

SYMSCAE commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

This PR reverts the change that vendors libdiffpy. CI is expected to fail until a new libdiffpy release is availble in conda.

SYMSCAE marked this pull request as draft October 12, 2026 22:01

SYMSCAE commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge PR ready for review. But I'll mark it as draft for now until we have a new libdiffpy release.

sbillinge reviewed Oct 13, 2026
View reviewed changes
Comment thread README.rst
SYMSCAE marked this pull request as ready for review October 19, 2026 01:35
SYMSCAE mentioned this pull request Oct 19, 2026
Open

sbillinge commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

@SYMSCAE this is still failing. It maybe just waiting for the upcoming release of libdiffpy? Please confirm and give an update on the progress there.

SYMSCAE commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@SYMSCAE this is still failing. It maybe just waiting for the upcoming release of libdiffpy? Please confirm and give an update on the progress there.

The tests fail for different reasons. This PR test fails because we reverted back to use external libdiffpy and I've set this to expect 1.5.0+ (it will fail for 1.4.0 for another reason since function signature changed).

The other two tests fail because the commit hash and checksum mismatches (which could be caused by branch changes and we shouldn't bother further as we're not vendoring libdiffpy).

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL