FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chored: fixed filenames by TingwenZhang · Pull Request #128 · diffpy/diffpy.structure · GitHub

Repository navigation

chored: fixed filenames - #128

Merged
sbillinge merged 2 commits into
diffpy:mainfrom
TingwenZhang:working-branch
Jun 2, 2025
Merged

sbillinge merged 2 commits into
diffpy:mainfrom
TingwenZhang:working-branch

Conversation

TingwenZhang commented Jun 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sbillinge
Could you take a look?

Closes #125

Copy link
Copy Markdown
Contributor

Thanks @TingwenZhang . please confirm what you did to check that none of the files changed are referred to anywhere.

Also, does this close an issue? Make sure to type closes # where you replace # with the issue number.

Copy link
Copy Markdown
Contributor Author

Yes, none of the files are referenced elsewhere. I added Closes #125.

sbillinge merged commit 4065098 into diffpy:main Jun 2, 2025

Copy link
Copy Markdown
Contributor

thanks @TingwenZhang

btw, that should have been chore, not chored :). A chore is a boring but required task like doing the dishes or taking out the trash. I get that you maybe wanted to make it into the past tense on the PR! :)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: ensure correct usage of underscores and hyphens for file and folder names

2 participants


Back | FazBrowse Home | New Git URL