FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skpkg: redo scikit-package with latest version with minimal fix by stevenhua0320 · Pull Request #152 · diffpy/diffpy.structure · GitHub

  1. diffpy
  2. diffpy.structure

Repository navigation

skpkg: redo scikit-package with latest version with minimal fix - #152

Merged
sbillinge merged 2 commits into
diffpy:mainfrom
stevenhua0320:skpkg-update
Feb 17, 2026
ConversationCommits (2)ChecksFiles changed
Merged

skpkg: redo scikit-package with latest version with minimal fix#152
sbillinge merged 2 commits into
diffpy:mainfrom
stevenhua0320:skpkg-update

Conversation

stevenhua0320 commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sbillinge ready to review. Note that most of these are done by automatic pre-commit hooks with very little exceptions:

  1. Note that there is no change to the license since for this package we have several license holders and we are not using the conventional BSD-3 license. Therefore, I maintain all of those instead of the changes by scikit-package.
  2. For the docstring of years, now it only gives the current year number, but I think it could be better if we also include the start year number (2024-2026). This is the fix I manually made here.
  3. For the author and the maintainers, as I believed now it adapts to include coauthors/comaintainers, but we don't need it here for this specific package. So I only include Prof Simon here as followed by the last version in pyproject.toml
    Closes Add support for python 3.14 and remove support of python 3.11 #148

codecov Bot commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.93%. Comparing base (730a91e) to head (64d4e59).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          13       13           
  Lines        1878     1878           
=======================================
  Hits         1858     1858           
  Misses         20       20
Files with missing lines Coverage Δ
tests/test_lattice.py 99.49% <100.00%> (ø)
tests/test_p_pdffit.py 99.41% <100.00%> (ø)
tests/test_parsers.py 99.47% <100.00%> (ø)
tests/test_spacegroups.py 98.00% <ø> (ø)
tests/test_structure.py 99.77% <100.00%> (ø)
tests/test_symmetryutilities.py 99.68% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

stevenhua0320 mentioned this pull request Feb 17, 2026
Closed
sbillinge merged commit 25d6efd into diffpy:main Feb 17, 2026
7 checks passed

sbillinge commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Thanks @stevenhua0320 this looks good. Please check tests for any warnings and try and resolve them. i presume that the tests are running on "latest" and so we may pick up some 3.14 deprecations

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for python 3.14 and remove support of python 3.11

2 participants

Back | FazBrowse Home | New Git URL