| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v3.4.0 #160 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 13 13
Lines 1905 1911 +6
=======================================
+ Hits 1885 1891 +6
Misses 20 20
|
Sorry, something went wrong.
|
@cadenmyers13 @stevenhua0320 thanks for catching this. I suggest that we don't do this work. We can either merge main into v3.4.0 if no other work has been done on main, or maybe better, just do nothing and it will all merge up when we do the final merge to main. We just need to remember which functions were incorrectly merged and not be tempted to do them over again.... |
Sorry, something went wrong.
|
@stevenhua0320 I would try to merge main into v3.4.0 if you can because having to remember will be tough. If the merge is challenging (ie lots of merge conflicts) try manually making the changes on v3.4.0. It might lead to minor merge conflicts when we eventually merge v3.4.0 into main but overall I think that would be an easier fix than having to remember later |
Sorry, something went wrong.
|
Can we close this PR so it doesn't accidentally get merged? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
@sbillinge ready to review. I realized that I merged to the wrong branch on upstream. It should be v3.4.0 instead of main branch. We should do a revert on the main for PR #158 .