chore: deprecate read/writeStr, placeInLattice method - #161
Merged
sbillinge merged 1 commit intoFeb 20, 2026
Merged
sbillinge merged 1 commit into
sbillinge merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v3.4.0 #161 +/- ##
==========================================
+ Coverage 98.95% 98.97% +0.01%
==========================================
Files 13 13
Lines 1919 1951 +32
==========================================
+ Hits 1899 1931 +32
Misses 20 20
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. Note that in Structure class we have a private camcelcase method that we need to deprecate, but I assume we don't have user call this function, so I only change the camelcase to lowercase and its corresponding usage.