FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: deprecate setLatPar and setLatBase method by stevenhua0320 · Pull Request #163 · diffpy/diffpy.structure · GitHub

  1. diffpy
  2. diffpy.structure

Repository navigation

chore: deprecate setLatPar and setLatBase method - #163

Merged
sbillinge merged 3 commits into
diffpy:v3.4.0from
stevenhua0320:deprecate-lattice
Feb 23, 2026
ConversationCommits (3)ChecksFiles changed
Merged

chore: deprecate setLatPar and setLatBase method#163
sbillinge merged 3 commits into
diffpy:v3.4.0from
stevenhua0320:deprecate-lattice

Conversation

stevenhua0320 commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

@sbillinge ready to review

codecov Bot commented Feb 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.99%. Comparing base (9c26c25) to head (74683b6).
⚠️ Report is 5 commits behind head on v3.4.0.

Additional details and impacted files 
@@            Coverage Diff             @@
##           v3.4.0     #163      +/-   ##
==========================================
+ Coverage   98.97%   98.99%   +0.01%     
==========================================
  Files          13       13              
  Lines        1951     1988      +37     
==========================================
+ Hits         1931     1968      +37     
  Misses         20       20
Files with missing lines Coverage Δ
tests/test_lattice.py 99.57% <100.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge reviewed Feb 23, 2026
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please see comment

Comment thread src/diffpy/structure/lattice.py Outdated
return

def setLatPar(
def set_lat_par(

sbillinge Feb 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

shall we call this set_latt_parms to make it clearer?

Comment thread src/diffpy/structure/lattice.py Outdated
"""
return self.set_lat_base(base)

def set_lat_base(self, base):

sbillinge Feb 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am not sure what this is tbh, but if we can figure it out, can we give it a better name?

stevenhua0320 Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This method sets a new base vector and update the cell length and angles according to the new base. I suggest making it set_new_latt_base_vec maybe?

sbillinge merged commit a7d43a1 into diffpy:v3.4.0 Feb 23, 2026
6 checks passed
hakonanes mentioned this pull request Mar 1, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL