chore: deprecate methods in symmetryutilities.py - #165
sbillinge merged 2 commits into
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v3.4.0 #165 +/- ##
==========================================
+ Coverage 98.99% 99.01% +0.01%
==========================================
Files 13 13
Lines 1995 2024 +29
==========================================
+ Hits 1975 2004 +29
Misses 20 20
|
Sorry, something went wrong.
sbillinge
left a comment
There was a problem hiding this comment.
please see comment
Sorry, something went wrong.
| readStr_deprecation_msg = build_deprecation_message( | ||
| base, | ||
| "isSpaceGroupLatPar", | ||
| "is_space_group_lat_par", |
There was a problem hiding this comment.
I suggest that we are consistent and abbreviate lattice to latt everywhere and parameter to parm or maybe better, param. Either way I think it is quite important that we use the same abbreviation for things everywhere they appear.
Sorry, something went wrong.
There was a problem hiding this comment.
Got it, I have made all lat to latt and parameter to parms since we have declared the name for parameter in the previous PR to be consistent. Furthermore, I realized I'm dumb to forget to edit the name of the method inside the argument, it should be readStr and read_structure here. See the latest commit.
Sorry, something went wrong.
@sbillinge ready to review. Note that I forgot to add the deprecation message for the readStr in the PDFFitStructure class in the past PR, so I add it here. Also note that for symmetryutilities.py there are a lot of new-written functions that created with no tests, I would consider how we handle with it in the next PR.