FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore:deprecate methods in `symmetryutilities.py` and add test for methods by stevenhua0320 · Pull Request #166 · diffpy/diffpy.structure · GitHub

  1. diffpy
  2. diffpy.structure

Repository navigation

chore:deprecate methods in symmetryutilities.py and add test for methods - #166

Merged
sbillinge merged 3 commits into
diffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-2
Feb 25, 2026
ConversationCommits (3)ChecksFiles changed
Merged

chore:deprecate methods in symmetryutilities.py and add test for methods#166
sbillinge merged 3 commits into
diffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-2

Conversation

stevenhua0320 commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

@sbillinge ready to review. Note that for these two methods originally we don't have test. I add two small tests to test the behavior, now it would give deprecationWarning.

sbillinge reviewed Feb 24, 2026
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please see inline comments

Comment thread tests/test_symmetryutilities.py Outdated
self.assertTrue(numpy.allclose(positionDifference([1.2, -0.1, 2.75], [0.1, 0.4, 0.25]), [0.1, 0.5, 0.5]))
return

def test_position_difference(self):

sbillinge Feb 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

these seem to b unittest tests. Please make all new tests you write as pytest tests (this doesn't apply to the ones that are copy-pasted as part of the depracation workflow).

If posisble, please use our canonical style expressing cases and expected behaviors.

codecov Bot commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (9a4195a) to head (6a25991).
⚠️ Report is 5 commits behind head on v3.4.0.

Additional details and impacted files 
@@           Coverage Diff           @@
##           v3.4.0     #166   +/-   ##
=======================================
  Coverage   99.01%   99.02%           
=======================================
  Files          13       13           
  Lines        2024     2041   +17     
=======================================
+ Hits         2004     2021   +17     
  Misses         20       20
Files with missing lines Coverage Δ
tests/test_symmetryutilities.py 99.72% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge merged commit 567f7fa into diffpy:v3.4.0 Feb 25, 2026
6 checks passed

sbillinge commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

That's great. Thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL