chore: deprecate method in GeneratorSite class - #168
Merged
sbillinge merged 2 commits intoFeb 26, 2026
Merged
sbillinge merged 2 commits into
sbillinge merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v3.4.0 #168 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 13 13
Lines 2071 2076 +5
=======================================
+ Hits 2051 2056 +5
Misses 20 20
|
Sorry, something went wrong.
sbillinge
reviewed
Feb 26, 2026
Comment thread
src/diffpy/structure/symmetryutilities.py
Outdated
| return | ||
|
|
||
| def _findeqUij(self): | ||
| def _find_equij(self): |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This could maybe be _find_eq_uij to make it more readable
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review