FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: deprecate getParser method across all parsers format. by stevenhua0320 · Pull Request #176 · diffpy/diffpy.structure · GitHub

Repository navigation

chore: deprecate getParser method across all parsers format. - #176

Merged
sbillinge merged 2 commits into
diffpy:v3.4.0from
stevenhua0320:deprecate-getParser
Mar 6, 2026
Merged

sbillinge merged 2 commits into
diffpy:v3.4.0from
stevenhua0320:deprecate-getParser

Conversation

Copy link
Copy Markdown
Contributor

@sbillinge ready to review.

codecov Bot commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (70aa675) to head (810ef8a).
⚠️ Report is 4 commits behind head on v3.4.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.4.0     #176   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          14       14           
  Lines        2359     2359           
=======================================
  Hits         2339     2339           
  Misses         20       20           
Files with missing lines Coverage Δ
tests/test_p_cif.py 99.69% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

this got conflicted. It looks similar to the PR I just merged so I am not sure what happened

stevenhua0320 commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sbillinge I have reviewed it, it is because of the incoming toLines setting message for deprecation in P_discus.py, I accepted the change there and it is ready to merge.

sbillinge merged commit 5ddd7b4 into diffpy:v3.4.0 Mar 6, 2026
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL