chore: deprecate spacegroup method - #180
Merged
sbillinge merged 1 commit intoMar 7, 2026
Merged
sbillinge merged 1 commit into
sbillinge merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v3.4.0 #180 +/- ##
==========================================
+ Coverage 99.16% 99.17% +0.01%
==========================================
Files 15 15
Lines 2400 2439 +39
==========================================
+ Hits 2380 2419 +39
Misses 20 20
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
looks good, thanks. If and when you make new tests, please try and make the pytest tests not unittest tests as a general rule. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review