Warning! No news item is found for this PR. If this is a user-facing
change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.
For best practices, please visit
https://scikit-package.github.io/scikit-package/snippets/news-file-format.html#how-do-i-create-a-news-file.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.21%. Comparing base (65d2729) to head (ea54de1).
⚠️ Report is 3 commits behind head on main.

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          15       15           
  Lines        2554     2554           
=======================================
  Hits         2534     2534           
  Misses         20       20           

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Thanks for catching that. Are there tests for that function that need to be updated?

I noticed the use of the deprecated function in a couple of tests. I assumed those were still there to test that the deprecation warning was properly emitted.

If you want I can update the tests.

Ok. Got it. I can merge this but we have to merge another OR that fixes the pre commit. Thanks for the PR! This PR doesn't require a news but please read about how we use that to maintain the changelog. Search for news on the scikit-package documentation if you are interested

Sounds good, thanks!

Thanks so much. We really appreciate contributions from the community!

Hi @sbillinge, any chance of making a release with this fix in?

yes, sure. We are waiting for it to pass CI so we can merge it. I think you need to merge main to get the pre-commit to pass.

@hakonanes are you able to merge main into your branch so we can pick up the pre-commit update and get CI passing?

Thanks @hakonanes. It looks as if this fix was part of the other cleaning that we did on the main branch so this PR is not showing any changes in the diff. We really appreciate your PR though and we hope you are able to contribute again in the future. It means a lot to us. when we get PRs from the community.

We pushed out some new releases in preparation for our presentation at the software fayre at IUCr so it is possible that if you simply conda update diffpy.structure in your env (or reinstall it) that you will get the updated version, but if you need us to push out these changes in a minor fix bump for some reason please reach back and we can do that.

Thanks again!

Hello @sbillinge, I'm also here from orix and kikuchipy.

Poking around a bit, conda and pypi are still showing version 3.4.0 from march 26th as the most recent version. I also don't see a version 3.4.1 tag in GitHub either.

Thanks, I will check up on where we are in the release cycle. Thanks for the jog

closing as no longer needed. Thanks for the contribution though.

I'm glad the change is in, thanks for following this up, @sbillinge. I can confirm that I don't see any warnings in the orix test suite after installing your 3.5.0 release candidate.

thanks @hakonanes I will push out the full release.