| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## migration #344 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 9 9
Lines 516 516
===========================================
Hits 516 516
|
Sorry, something went wrong.
I believe it is already in scikit-package v0.1.0. It is just you built your env using requirements/docs.txt before updating..... |
Sorry, something went wrong.
|
@sbillinge Oh you're right, I must've got rid of it when I moved requirements over! |
Sorry, something went wrong.
There was a problem hiding this comment.
looks good. I am confused now, because I believe that copybutton is in skpkg 0.1.0 so I am not sure why you are having to manually add it here. Please see my other comment and then I an merge.
Sorry, something went wrong.
|
@sbillinge see above response about copybutton, it was a fault on my end! |
Sorry, something went wrong.
slow and steady wins the race! |
Sorry, something went wrong.
|
Brilliant, is that a wrap (bar testing)? |
Sorry, something went wrong.
|
@sbillinge pytest passes on a fully sync'd migration branch. Is there any other testing that needs to be done? |
Sorry, something went wrong.
|
normally we would quickly run through any tutorial. Could you take a look if there is one? But then we can merge. I htink you can create a PR, migration -> main when you are ready. |
Sorry, something went wrong.
|
@cadenmyers13 don't forget the "closes #" close the skpkg issue for that migration -> main PR. |
Sorry, something went wrong.
@sbillinge will do. There are tutorials for this. ill run them and let you know if i run into any bugs |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Final PR for the current skpkg'ing of diffpy.utils! After this is merged we should be able to merge migration into main once tested.
I had to install sphinx-copybutton to build docs locally so i added that to requirements. Maybe this needs to be added to scikit-package?