FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: fix the `diffpy.utils.transforms.d_to_tth` example by ycexiao · Pull Request #357 · diffpy/diffpy.utils · GitHub

  1. diffpy
  2. diffpy.utils

Repository navigation

docs: fix the diffpy.utils.transforms.d_to_tth example - #357

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
ycexiao:fix-docs-example
Jul 25, 2025
ConversationCommits (1)ChecksFiles changed
Merged

docs: fix the diffpy.utils.transforms.d_to_tth example#357
sbillinge merged 1 commit into
diffpy:mainfrom
ycexiao:fix-docs-example

Conversation

ycexiao commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR address

Closes #352

Remove a d value from the documentation that will raise ValueError.

github-actions Bot commented Jul 25, 2025

Copy link
Copy Markdown

Warning! No news item is found for this PR. If this is a user-facing
change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.
For best practices, please visit
https://scikit-package.github.io/scikit-package/frequently-asked-questions.html#billinge-group-standards.

codecov Bot commented Jul 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (44328a2) to head (3ea591b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          520       520           
=========================================
  Hits           520       520
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ycexiao marked this pull request as ready for review July 25, 2025 20:52

ycexiao commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge, it's ready for review. The news file has already been added in #354. These two PR address the same problem (documentation examples), so I didn't create a new file for this one.

sbillinge merged commit 1163ae8 into diffpy:main Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: some parts in documentation are incorrect.

2 participants

Back | FazBrowse Home | New Git URL