Repository navigation
Normalize paths before assert - #359
Merged
sbillinge merged 1 commit intoAug 21, 2025
Merged
sbillinge merged 1 commit into
sbillinge merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #359 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 520 520
=========================================
Hits 520 520
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Merged. Do we have to push out a new patch-release for cmi tests to pass? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@sbillinge Not really necessary. I already released one in my personal fork and now cmi tests are using that release. Also made an issue diffpy/diffpy.cmi#35 on this. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge please check, thanks
Normalize paths before assert in test_serialization/test_load_multiple to prevent possible Windows short/long name mismatch.