FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

scikit:recut diffpy.utils using latest scikit-package. by stevenhua0320 · Pull Request #369 · diffpy/diffpy.utils · GitHub

  1. diffpy
  2. diffpy.utils

Repository navigation

scikit:recut diffpy.utils using latest scikit-package. - #369

Merged
sbillinge merged 3 commits into
diffpy:mainfrom
stevenhua0320:scikit-package-1
Dec 18, 2025
ConversationCommits (3)ChecksFiles changed
Merged

scikit:recut diffpy.utils using latest scikit-package.#369
sbillinge merged 3 commits into
diffpy:mainfrom
stevenhua0320:scikit-package-1

Conversation

stevenhua0320 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

@sbillinge ready to review, most of the changes are reformatting of the documentation

codecov Bot commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (52702e2) to head (f0d2a4d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          520       520           
=========================================
  Hits           520       520
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge reviewed Dec 18, 2025
View reviewed changes

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please see linline comments.

Comment thread pyproject.toml Outdated
namespaces = false # to disable scanning PEP 420 namespaces (true by default)

[project.scripts]
diffpy-utils = "diffpy.utils.app:main"

sbillinge Dec 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is wrong, it should have an underscore. As well as fixing here, this is presumably still a bug in scikit-package if you used the latest version.

stevenhua0320 Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh yes, we should also create an issue in scikit-package that the symbol before app should be an underscore

sbillinge merged commit 64ad577 into diffpy:main Dec 18, 2025
7 checks passed

sbillinge commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

thanks @stevenhua0320.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL