FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Remove API for calculating mu from packing fraction by cadenmyers13 · Pull Request #370 · diffpy/diffpy.utils · GitHub

Repository navigation

fix: Remove API for calculating mu from packing fraction - #370

Merged
sbillinge merged 3 commits into
diffpy:mainfrom
cadenmyers13:rm-packing-fraction
Dec 29, 2025
Merged

sbillinge merged 3 commits into
diffpy:mainfrom
cadenmyers13:rm-packing-fraction

Conversation

Copy link
Copy Markdown
Contributor

closes #339

I dont believe a test is needed since this is basically a wrapper for for material_mu in xraydb.

cadenmyers13 changed the title fix: Remove API for calculating fix: Remove API for calculating mu from packing fraction Dec 21, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review

codecov Bot commented Dec 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (64ad577) to head (d41a817).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #370   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          520       516    -4     
=========================================
- Hits           520       516    -4     
Files with missing lines Coverage Δ
tests/test_tools.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbillinge merged commit aab1765 into diffpy:main Dec 29, 2025
7 checks passed

Copy link
Copy Markdown
Contributor

nice!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Remove pakcing_fraction option from compute_mu_from_xraydb

2 participants


Back | FazBrowse Home | New Git URL