Repository navigation
bug: docstring print statement bug - #380
Merged
sbillinge merged 2 commits intoFeb 4, 2026
Merged
sbillinge merged 2 commits into
sbillinge merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@sbillinge ready for review. The docstring print function didnt handle the None case nicely. Let me know what you think here |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #380 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 567 567
=========================================
Hits 567 567
|
Sorry, something went wrong.
18 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was printing a bad docstring because we didnt handle the None case. it printed like this,
Now, if new_base=None, the print statement will look like
optionally, we can make the user always specify a base.