| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@stevenhua0320 PR ready to review. |
Sorry, something went wrong.
|
This looks good to me, although the workflow seems not triggering the test-on-pr workflow, we are only doing linting and update for pre-commit, so we are safe to merge. @sbillinge ready for review. |
Sorry, something went wrong.
|
please double-check the docformatter tool in pyproject.toml. I think it may be ok, but let's make sure it is inheriting all the parameters we want to roll out across all packages. Other than that LGTM and I can merge when it passes tests. |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #386 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 567 567
=========================================
Hits 567 567
|
Sorry, something went wrong.
|
Here is the docformatter config in pyproject.toml [tool.docformatter] recursive = true wrap-summaries = 72 wrap-descriptions = 72 I think we are right here as we have all these across other packages, so we are safe to merge this. |
Sorry, something went wrong.
| - id: docformatter | ||
| additional_dependencies: [tomli] | ||
| args: [--in-place, --config, ./pyproject.toml] | ||
| language_version: python3.13 |
There was a problem hiding this comment.
What is this? We don't want any pins like this is possible. If a pin is necessary we need an issue to remove it in the future. But better to find a fix that is not a workaround
Sorry, something went wrong.
There was a problem hiding this comment.
We made this is because now we decide to use 1.7.7 docformatter but this version does not support python 3.14, so we add the pin to the python version here. We had to wait for the 1.7.8 wierd deleting line bug to fix so that we could remove the pin and I think everything would work smoothly again. So, we should make an issue and notify future developers to remove this pin and change to 1.7.8 version when the bug is fixed. I also made the update to the issue #385
Sorry, something went wrong.
There was a problem hiding this comment.
ok, we can't use 1.7.7 then.
Sorry, something went wrong.
There was a problem hiding this comment.
we will have to find another workaround with 1.7.8
Sorry, something went wrong.
This reverts commit 4b7583e.
| Back | FazBrowse Home | New Git URL |
Summary
This PR performs pre-commit hook maintenance by updating tooling hook revisions.
Changes