FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump libobjcryst version by Sparks29032 · Pull Request #32 · diffpy/libdiffpy · GitHub

Repository navigation

Bump libobjcryst version - #32

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
Sparks29032:main
Oct 15, 2026
Merged

sbillinge merged 4 commits into
diffpy:mainfrom
Sparks29032:main

Conversation

Copy link
Copy Markdown
Contributor

Installing libdiffpy causes libobjcryst versions to downgrade

Copy link
Copy Markdown
Contributor

@SYMSCAE @Sparks29032 please can you look at this and see if everything is ok? I updated the libobjcryst version to the latest but wasn't sure about the gsl and whether we still need boost here and what version.

SYMSCAE commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@SYMSCAE @Sparks29032 please can you look at this and see if everything is ok? I updated the libobjcryst version to the latest but wasn't sure about the gsl and whether we still need boost here and what version.

Tests all passed. In actual computation, there is deviation around 10^-10 ~ level (see graph below) due to gsl update. Please see if these difference matters.

For Boost, we should sync with libobjcryst's need to 1.88.

Copy link
Copy Markdown
Contributor

I updated gsl to 2.8 and boost to 1.88. @SYMSCAE please could you quickly check the tests again? The change at >10-10 you noted is ok.

SYMSCAE commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

I updated gsl to 2.8 and boost to 1.88. @SYMSCAE please could you quickly check the tests again? The change at >10-10 you noted is ok.

I've just tested and there's no difference between this and 2.7.

sbillinge merged commit e6e11af into diffpy:main Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL