FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add: auto release with sha by Tieqiong · Pull Request #39 · diffpy/libdiffpy · GitHub

Repository navigation

add: auto release with sha - #39

Merged
sbillinge merged 1 commit into
diffpy:windowsfrom
Tieqiong:workflow
Jun 24, 2025
Merged

sbillinge merged 1 commit into
diffpy:windowsfrom
Tieqiong:workflow

Conversation

Copy link
Copy Markdown
Contributor

@sbillinge please check, thanks

This will automatically GitHub release after a tag being pushed by maintainer or admin with the tag message + correct sha256 in the release message

sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is nice. We are using centralized workflows now, in scikit-package/release scripts. To reduce maintenance in the future, please could you look into incorportating this as much as possible into a more centralized worklow that we just call from here? You can loop in Bob with questions.

Copy link
Copy Markdown
Contributor Author

@sbillinge Thanks for the suggestion. The point of a centralized workflow is to offer a reusable, consistent process—but our C++ library’s build and release steps are quite different from our Python packages, and we don’t yet have a skpkg standard for C++ modules. Folding this into the central repo today would either clutter it with C++-specific logic or introduce extra layers here, without real benefit.
Since we expect this library to be heavily modified and updated, with any possible future skpkg C++ standard to evolve rapidly, a temporary dedicated workflow in this repo is simpler and more maintainable for now. Once we’ve defined a skpkg C++ standard, we can migrate it back upstream.

Copy link
Copy Markdown
Contributor

sounds good. I agree.

sbillinge merged commit ec370af into diffpy:windows Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL