| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
remove travis ci and local conda recipe
I would add a pyproject.toml. it only needs to have the [tool.black] and [tool.codespell] blocls in it. Nothing about building the package. Will this break setuptools for everything else if we do that? |
Sorry, something went wrong.
|
cpplint would be good but let's get everything working first. |
Sorry, something went wrong.
|
remove travis and conda recipe": correct |
Sorry, something went wrong.
|
is there a reason why the tests are not funning on the PR? Do tests pass? |
Sorry, something went wrong.
|
@sbillinge Thanks for the comments. This cpp library doesn't use setuptool, and I think adding a pyproject.toml is fine. We never got the original tests to work, and I believe we discussed this before and decided to rewrite all tests using modernized cpp testing suits. All the tests on this for now depend on diffpy.srreal. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
We should discuss on how we setup codespell here, as in regular skpkg packages we refer to ignore_words and ignore_lines in pyproject.toml, which doesn't exist here. I'm able to use the ignore_word file directly into pre-commit.yaml by making it a shell command (which force the comment symbol from ;; to # ), but I'm not sure how to add ignore_lines.
We might also want to add an extra cpplint check after some maintenance is done on the code. I already added it in .pre-commit-config.yaml but commented out for now.
@sbillinge please check, thanks!