Repository navigation
Add profile ReflectionProfilePseudoVoigtTCH with TCH instead of explicit Eta mixing - #115
Merged
vincefn merged 5 commits intoSep 24, 2026
Merged
vincefn merged 5 commits into
vincefn merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…f explicit Eta mixing
…ofilePseudoVoigtTCH by default, P=0 and LGmix=1 LGmix=0 means Gaussian, LGmix=1 means Lorentzian broadening
Copy link
Copy Markdown
Contributor
Author
|
@vincefn @sbillinge I bumped libobjcryst to 2026.3.0 and tests pass 🥳 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires vincefn/objcryst#97
See vincefn/objcryst#97 for description. In short, it's an isotropic Pseudo-Voigt model for the peak shape with similar parameterization as GSAS-II.
In contrast to existing models ReflectionProfilePseudoVoigt(Anisotropic) it implicitely computes the Eta mixing parameter from the TCH approximation instead of exposing it as a refinable parameter.