btrbk: default to start weeks on mondays - #510
Open
calestyo wants to merge 1 commit into
Open
calestyo wants to merge 1 commit into
calestyo wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Changed the default of the `preserve_day_of_week`-option to `monday` in accordance with the start of an ISO 8601 week as well as the meaning of `weekly` systemd. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Copy link
Copy Markdown
Contributor
Author
|
@digint Could you possibly review? :-) |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
This will break setup for 99% of btrbk users at once. "sunday" was chosen because for most people it makes sense to keep the backup from the weekend. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Well... for that one has changelogs or news files… or major versions where one could make such changes. I mean it's not a super important change, so if you're strictly against it... I don't mind. But I guess it's clear that the future is systemd, whether one likes it or not, and there weeks start on Mondays, so it would be a nicer fit. |
Sorry, something went wrong.
digint
force-pushed
the
master
branch
6 times, most recently
from
594fc6d to
dac6350
Compare
August 5, 2023 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the default of the preserve_day_of_week-option to monday in accordance with the start of an ISO 8601 week as well as the meaning of weekly systemd.
Signed-off-by: Christoph Anton Mitterer mail@christoph.anton.mitterer.name