| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Oops, I just saw this PR after I fixed this in #617. I'm also supporting --long[=N] which man zstd says is required for --adapt to work. |
Sorry, something went wrong.
|
@digint Is there anything I can do to get this merged? |
Sorry, something went wrong.
Are you also supporting --long[=N] which man zstd says is required for --adapt to work? (See my PR for hints and maybe other improvements too?) |
Sorry, something went wrong.
|
@HaleTom I believe --long is not actually required for --adapt; the wording on the man page is unfortunately just confusing- it is saying "you may combine this with --long". What it requires is non-single threaded mode; you can check this with cat /dev/zero | zstd --adapt --single-thread and see it spits back an error but cat /dev/zero | zstd --adapt -v > /dev/null works, as you can see via the -v. This PR does not support --long though, as it's a separate feature. I'm fine with either PR being merged depending on if @digint is fine with --long or not. |
Sorry, something went wrong.
|
I'm likewise fine with either PR being accepted. I think that mine's (#617) neater because:
|
Sorry, something went wrong.
I really hope to get some time next week to work on btrbk, and especially also to look at this MR (and @HaleTom 's). |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR fixes: