Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (c577ba6) to head (896a4d0).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   83.71%   84.81%   +1.09%     
==========================================
  Files           5        5              
  Lines         393      316      -77     
==========================================
- Hits          329      268      -61     
+ Misses         54       38      -16     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

/cc @tonistiigi

Yes; regexes being "hungry" on resources is a known issue in general, which is also why Kir made various pull requests some time ago to try to reduce their use (e.g. docker/go-units#40), but this one cam through @tonistiigi who found that docker/buildx forgot to update docker/registry to the latest version, and as a result the distribution/reference package was loaded twice (once from docker/distribution/reference` and once from the new module.

For a long-lived process / daemon, it's probably less problematic, but in the CLI, this resulted in nearly 2MB to be used just by importing those packages; here's from a Slack thread on that;

reference package(s) allocate nearly 2MB of memory inside init()

init github.com/containerd/containerd/reference @68 ms, 0.002 ms clock, 776 bytes, 10 allocs
init github.com/distribution/reference @68 ms, 1.5 ms clock, 414456 bytes, 3599 allocs
init github.com/docker/distribution/reference @70 ms, 2.2 ms clock, 1368728 bytes, 11434 allocs

So this is an attempt at reducing such cases, and making the regexes compiled on first use.

@thaJeztah now that #16 has been merged, wanna open this for review?

ping @thaJeztah

We need to bump Go on this repo 🙈

@milosgajdos failure was because an invalid golangci-lint.yaml option (deadline was removed from the schema, and now had to be timeout, but both were deprecated in v2); I opened a PR to refresh CI, but it looks like the repository's config is looking for the Analyze (go) and CodeQL actions to start running, and .. they don't (or they have a different name now, for it to not find them 🫠);

• ci: update actions to current versions, golangci-lint v2, test against latest go versions #21