FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: update actions to current versions, golangci-lint v2, test against latest go versions by thaJeztah · Pull Request #21 · distribution/reference · GitHub

ci: update actions to current versions, golangci-lint v2, test against latest go versions - #21

Merged
milosgajdos merged 6 commits into
distribution:mainfrom
thaJeztah:bump_gha
Apr 11, 2025
Merged

ci: update actions to current versions, golangci-lint v2, test against latest go versions#21
milosgajdos merged 6 commits into
distribution:mainfrom
thaJeztah:bump_gha

Conversation

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

codecov Bot commented Apr 11, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.71%. Comparing base (343e590) to head (f0f7bf2).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   84.21%   83.71%   -0.50%     
==========================================
  Files           5        5              
  Lines         304      393      +89     
==========================================
+ Hits          256      329      +73     
- Misses         38       54      +16     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member Author

Looks like CodeQL doesn't start because it's been a while since it ran;

We could probably add a scheduled job for it as well

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Copy link
Copy Markdown
Member Author

We could probably add a scheduled job for it as well

Interestingly, looks like we already have, so not sure why that didn't keep actions "alive"?;

on:
schedule:
- cron: '0 12 * * 6'
push:

thaJeztah marked this pull request as ready for review April 11, 2025 10:44

Copy link
Copy Markdown
Member Author

The CodeCov is probably missing data, or it's just a rounding error 😓

Copy link
Copy Markdown
Member Author

Not sure how to handle those 2 actions; I don't have access to the repo config, but it's worth checking how they're defined and if the repo-settings / branch protection needs updating (they're a big pain to set up if names change etc).

Copy link
Copy Markdown
Member

CodeQL Action major versions v1 and v2 have been deprecated. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2025-01-10-code-scanning-codeql-action-v2-is-now-deprecated/Show more

Need tot upgrade that workflow 😅

Copy link
Copy Markdown
Member Author

LOL; that's what this PR does. Fun chicken-and-egg case then?

Copy link
Copy Markdown
Member

I'm inclined to merge this. There is no way forward. Thoguhts?

Copy link
Copy Markdown
Member Author

Yeah, easiest is to remove them from the "required" checks in branch protection, then after it's merged, we can probably add them back

Copy link
Copy Markdown
Member

Done, let's merge

Copy link
Copy Markdown
Member Author

SGTM; I don't have permissions though ☺️

milosgajdos merged commit e3db434 into distribution:main Apr 11, 2025
thaJeztah deleted the bump_gha branch April 17, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL