FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Import dnssecjava by ibauersachs · Pull Request #209 · dnsjava/dnsjava · GitHub

/ dnsjava Public

Import dnssecjava - #209

Merged
ibauersachs merged 12 commits into
masterfrom
dnssec
Jan 23, 2022
ConversationCommits (12)ChecksFiles changed
Merged

Import dnssecjava#209
ibauersachs merged 12 commits into
masterfrom
dnssec

Conversation

ibauersachs commented Aug 15, 2021

Copy link
Copy Markdown
Member

Closes #172

ibauersachs force-pushed the dnssec branch 3 times, most recently from 31976d5 to 3ccb913 Compare August 15, 2021 21:32

sonarqubecloud Bot commented Aug 15, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
13 Code Smells

93.8% Coverage
0.0% Duplication

codecov-commenter commented Aug 15, 2021 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.42357% with 156 lines in your changes missing coverage. Please review.

Project coverage is 63.61%. Comparing base (4eff203) to head (b37ba45).
Report is 159 commits behind head on master.

Files with missing lines Patch % Lines
.../main/java/org/xbill/DNS/dnssec/NSEC3ValUtils.java 77.61% 42 Missing and 20 partials ⚠️
.../java/org/xbill/DNS/dnssec/ValidatingResolver.java 92.38% 35 Missing and 11 partials ⚠️
src/main/java/org/xbill/DNS/dnssec/ValUtils.java 90.05% 23 Missing and 11 partials ⚠️
...main/java/org/xbill/DNS/dnssec/DnsSecVerifier.java 85.18% 9 Missing and 3 partials ⚠️
src/main/java/org/xbill/DNS/dnssec/KeyCache.java 96.07% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #209      +/-   ##
============================================
+ Coverage     57.26%   63.61%   +6.34%     
- Complexity     2088     2735     +647     
============================================
  Files           163      178      +15     
  Lines         10907    12509    +1602     
  Branches       1573     1902     +329     
============================================
+ Hits           6246     7957    +1711     
+ Misses         4235     4081     -154     
- Partials        426      471      +45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ibauersachs added this to the v3.5 milestone Aug 24, 2021
ibauersachs mentioned this pull request Aug 29, 2021
Closed

sonarqubecloud Bot commented Dec 25, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
14 Code Smells

92.4% Coverage
0.0% Duplication

ibauersachs requested a review from nresare December 25, 2021 22:51

ibauersachs commented Dec 25, 2021

Copy link
Copy Markdown
Member Author

@nresare I think this is ready for merging, can you have a look please? I'm mainly interested in comments about the API, the entire content is probably too much.

nresare approved these changes Jan 22, 2022
View reviewed changes

nresare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is obviously a very substantial diff that it is difficult to review all aspects of, but I had a brief look and it seems to me like a solid improvement to dnsjava. Let's land this, and we can come back to any outstanding issues later :)

ibauersachs merged commit f4f563b into master Jan 23, 2022
ibauersachs deleted the dnssec branch January 23, 2022 12:54
darakian mentioned this pull request Sep 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nresare nresare approved these changes
+1 more reviewer
hyperxpro hyperxpro left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.5

Development

Successfully merging this pull request may close these issues.

Merge dnssecjava into dnsjava

4 participants

Back | FazBrowse Home | New Git URL