refactor: instances of parametrized tensors are no longer parametrized - #1026
Merged
samsja merged 12 commits intoJan 25, 2023
Merged
refactor: instances of parametrized tensors are no longer parametrized#1026samsja merged 12 commits into
samsja merged 12 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Jackmin801
force-pushed
the
feat-994-dropshape
branch
2 times, most recently
from
399309b to
393b664
Compare
January 17, 2023 15:05
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Jackmin801
force-pushed
the
feat-994-dropshape
branch
from
16c7c6d to
8c5e3f0
Compare
January 17, 2023 15:40
JohannesMessner
requested changes
Jan 17, 2023
Comment thread
docarray/typing/tensor/abstract_tensor.py
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
samsja
approved these changes
Jan 23, 2023
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-feat-994-dropshape--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
JohannesMessner
approved these changes
Jan 25, 2023
JoanFM
pushed a commit
that referenced
this pull request
Jan 26, 2023
#1026) * test: add tensor ops tests Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * feat: instances of parametrized types are not parametrized anymore Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * test: fix test that have been changed by this feature Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * refactor: change class name and add comments Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * test: add tests to make sure isinstance does not do coercion Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * fix: parametrized isinstance check should not perform coercion Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * test: add more tests to parametrized class name tests Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> * style: small black fix Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com> Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because parametrizing them can cause them to be wrong when operations are performed.
We only need the parametrization during instantiation for validation.
After that, we make no guarantees about the shape.
Goals: