FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add docs for dict() method by punndcoder28 · Pull Request #1643 · docarray/docarray · GitHub

/ docarray Public

docs: add docs for dict() method - #1643

Merged
JoanFM merged 1 commit into
docarray:mainfrom
punndcoder28:docs-update-dict
Jul 5, 2023
ConversationCommits (1)ChecksFiles changed
Merged

docs: add docs for dict() method#1643
JoanFM merged 1 commit into
docarray:mainfrom
punndcoder28:docs-update-dict

Conversation

punndcoder28 commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Fixes #1560 by adding detailed doc for the base_doc.dict() method describing how it is different from the python method dict()

punndcoder28 mentioned this pull request Jun 12, 2023
Closed
JoanFM changed the title docs: add docs for dic() method docs: add docs for dict() method Jun 12, 2023

JoanFM commented Jun 12, 2023

Copy link
Copy Markdown
Member

Hello @punndcoder28,

Thank you very much for the contribution.

We need you to sign off the commits in the PR before we can merge the contribution.

samsja reviewed Jun 13, 2023
View reviewed changes
Comment thread docarray/base_doc/doc.py
punndcoder28 requested a review from samsja June 13, 2023 09:59

punndcoder28 commented Jun 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @samsja Thanks for the review. I have updated the doc with suggested changes.

@JoanFM I have signed off the latest commit, will I have to do it for each and every commit in the PR. I tried to amend the commit last night to have the sign off message but couldn't since it was complaining that there were no changes to push. Should have tried to force push to the branch

punndcoder28 commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

Hi guys @JoanFM @samsja Is this being waited on because of the unverified initial commit?

docs: add docs for dic() method
90d46b8 
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>

punndcoder28 commented Jul 1, 2023

Copy link
Copy Markdown
Contributor Author

@samsja any updates on the timeline to review and merge this PR?

JoanFM merged commit 5089bda into docarray:main Jul 5, 2023
jupyterjazz mentioned this pull request Jul 18, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JoanFM JoanFM approved these changes
samsja Awaiting requested review from samsja

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: add docs for the dict() method

3 participants

Back | FazBrowse Home | New Git URL