| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
This looks mostly good ! Once we have :
we will be good to go
Sorry, something went wrong.
There was a problem hiding this comment.
looks really good. I added some tiny comments.
We are just missing the interagration test before we merge !
Sorry, something went wrong.
|
btw looking at the CI it seems that you still have place where you load jax without using the helper import and therefore it throw an error |
Sorry, something went wrong.
|
Hey @agaraman0 , would it be possible for you to add a code snippet as an example of the usage of this feature in the PR description. Like this we can add it in future release notes to highlight this awesome feature. |
Sorry, something went wrong.
Sure will do that, I am just looking for some existing example if I can replicate one. |
Sorry, something went wrong.
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
|
@agaraman0 can you add an equivalent test to the one added for Pytorch and TF in this PR #1696 |
Sorry, something went wrong.
Signed-off-by: agaraman0 <agaraman0@gmail.com>
There was a problem hiding this comment.
I think I found all docstrings. A few changes recommended.
Sorry, something went wrong.
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Sorry, something went wrong.
There was a problem hiding this comment.
Great PR looking forward to merge
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Integrating JAX as a computation backend in Docarray similar to Pytorch, Tensorflow, and Numpy