feat: add method to create BaseDoc from schema - #1667
Merged
JoanFM merged 8 commits intoJun 22, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
feat-add-create-dynamic-doc
branch
from
8d3d297 to
4b018d8
Compare
June 21, 2023 10:48
JoanFM
force-pushed
the
feat-add-create-dynamic-doc
branch
from
c5580ba to
0ea3a28
Compare
June 21, 2023 16:59
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
feat-add-create-dynamic-doc
branch
from
0ea3a28 to
e5f065f
Compare
June 21, 2023 17:01
JohannesMessner
requested changes
Jun 22, 2023
Comment thread
docarray/utils/create.py
Outdated
Comment thread
docarray/utils/create.py
Comment thread
docarray/utils/create.py
Outdated
Comment thread
docarray/utils/create.py
Outdated
Comment thread
docarray/utils/create.py
Comment thread
docarray/utils/create.py
Outdated
Comment thread
docarray/utils/create.py
Outdated
Comment thread
tests/units/util/test_create.py
Outdated
Comment thread
docarray/utils/create.py
JoanFM
force-pushed
the
feat-add-create-dynamic-doc
branch
from
d4d6b8b to
e2d41f0
Compare
June 22, 2023 07:59
Comment thread
docarray/utils/create.py
Outdated
JoanFM
force-pushed
the
feat-add-create-dynamic-doc
branch
2 times, most recently
from
4060c31 to
10204ad
Compare
June 22, 2023 08:04
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: Joan Fontanals <jfontanalsmartinez@gmail.com> Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
feat-add-create-dynamic-doc
branch
from
10204ad to
be35141
Compare
June 22, 2023 08:07
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
feat-add-create-dynamic-doc
branch
from
4c040a0 to
97c07e5
Compare
June 22, 2023 08:17
samsja
reviewed
Jun 22, 2023
Comment thread
docarray/utils/create_dynamic_doc_class.py
Outdated
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-feat-add-create-dynamic-doc--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
samsja
approved these changes
Jun 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is used inside Jina to dynamically create BaseDocs in services where the actual BaseDoc is not created but still hold the validation capabilities.
You can think as being easy to validate the BaseDoc at the driver or client program of a server serving BaseDoc models.