fix: better error message when docvec is unusable - #1675
Merged
JoanFM merged 3 commits intoJun 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
JohannesMessner
commented
Jun 27, 2023
Comment thread
docarray/array/any_array.py
|
|
||
| UNUSABLE_ERROR_MSG = ( | ||
| 'This {cls} instance is in an unusable state. \n' | ||
| 'The most common cause of this is converting a DocVec to a DocList. ' |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Right now this is the only cause, actually, but I wanted to keep our options open here.
Sorry, something went wrong.
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
JoanFM
requested changes
Jun 27, 2023
JoanFM
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why is it unusable?
Sorry, something went wrong.
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-fix-vec-to-list-error-msg--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Because to_doc_list() directly modifies the data stored in the columns in order to not copy the data. This "destroys" the columns. |
Sorry, something went wrong.
JoanFM
approved these changes
Jun 27, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1563
The approach is to set a flag _is_unasable as soon as the instance gets unusable, and from that point onward raise an Exception at every getatts/setattr interaction.
Unfortunately we cannot override getattr/setattr on the fly (and get rid of the _is_unasable) flag: https://stackoverflow.com/questions/10376604/overriding-special-methods-on-an-instance