FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: avoid converting doclists in the base index by jupyterjazz · Pull Request #1685 · docarray/docarray · GitHub

fix: avoid converting doclists in the base index - #1685

Merged
jupyterjazz merged 1 commit into
mainfrom
fix-dont-convert-doclist
Jul 5, 2023
Merged

fix: avoid converting doclists in the base index#1685
jupyterjazz merged 1 commit into
mainfrom
fix-dont-convert-doclist

Conversation

Copy link
Copy Markdown
Contributor
if isinstance(docs, List):
    docs = self._dict_list_to_docarray(docs)

_dict_list_to_docarray expects a list of dictionaries which is then transformed into a DocList. However, since DocList extends List, the condition is true even if docs is already a DocList, which then leads to an error.

We already fixed this in one place but there are other parts too that need an extra check.

Found while working on milvus pr

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>

github-actions Bot commented Jul 5, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-dont-convert-doclist--jina-docs.netlify.app 🎉

jupyterjazz marked this pull request as ready for review July 5, 2023 11:27
jupyterjazz merged commit f6ce283 into main Jul 5, 2023
jupyterjazz deleted the fix-dont-convert-doclist branch July 5, 2023 11:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL