fix: use safe_issubclass everywhere - #1691
Merged
JoanFM merged 2 commits intoJul 10, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JoanFM
force-pushed
the
fix-is-subclass
branch
4 times, most recently
from
fea121b to
a31493b
Compare
July 10, 2023 12:36
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
requested review from
JohannesMessner,
alaeddine-13,
hsm207,
jupyterjazz,
maxwelljin and
samsja
and removed request for
JohannesMessner,
hsm207 and
samsja
July 10, 2023 12:48
samsja
approved these changes
Jul 10, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-fix-is-subclass--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1690
#1690 fails with an exception that is covered by safe_issubclass. Not sure why we did not completely migrated to using this method, but this PR aims to do so