refactor: contains method in the base class - #1701
Merged
jupyterjazz merged 3 commits intoJul 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Copy link
Copy Markdown
Codecov ReportPatch coverage: 88.88% and project coverage change: +0.05 🎉 Additional details and impacted files @@ Coverage Diff @@
## main #1701 +/- ##
==========================================
+ Coverage 85.88% 85.94% +0.05%
==========================================
Files 126 126
Lines 7899 7890 -9
==========================================
- Hits 6784 6781 -3
+ Misses 1115 1109 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-refactor-docindex-contains--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
samsja
approved these changes
Jul 17, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small refactoring: put contains method in the base class and ask backends to implement _doc_exists