docs: add workaround for torch compile - #1754
Merged
samsja merged 12 commits intoAug 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Copy link
Copy Markdown
Codecov ReportPatch coverage has no change and project coverage change: +1.25% 🎉 Additional details and impacted files @@ Coverage Diff @@
## main #1754 +/- ##
==========================================
+ Coverage 83.74% 84.99% +1.25%
==========================================
Files 134 134
Lines 8845 8845
==========================================
+ Hits 7407 7518 +111
+ Misses 1438 1327 -111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
JohannesMessner
marked this pull request as ready for review
August 29, 2023 06:59
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-docs-torch-compile--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
samsja
approved these changes
Aug 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing torch compilation with TorchTensor is blocked by upstream (see here: #1753), so i'm adding workaround to the docs.
Torch 2.0.1 and poetry don't seem to like each other (see: https://stackoverflow.com/a/76647180) so i had to introduce a bunch of pip uninstall torch / pip install torch to make torch work on the CI.