docs: improve filtering docstrings - #1762
Merged
JoanFM merged 3 commits intoAug 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportPatch coverage has no change and project coverage change: -0.68% ⚠️ Additional details and impacted files @@ Coverage Diff @@
## main #1762 +/- ##
==========================================
- Coverage 84.99% 84.31% -0.68%
==========================================
Files 134 134
Lines 8845 8845
==========================================
- Hits 7518 7458 -60
- Misses 1327 1387 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
docstring-filter
branch
from
8c0582f to
705abf3
Compare
August 24, 2023 06:39
Comment thread
docarray/utils/filter.py
Outdated
Co-authored-by: Scott Martens <70647348+scott-martens@users.noreply.github.com> Signed-off-by: Joan Fontanals <jfontanalsmartinez@gmail.com>
scott-martens
approved these changes
Aug 24, 2023
scott-martens
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
docstring-filter
branch
from
63fc62f to
744443d
Compare
August 24, 2023 07:43
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-docstring-filter--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per suggestion in #1749, Some better documentation about the syntax of the filtering query is required