| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Codecov ReportPatch coverage: 100.00% and project coverage change: +0.13% 🎉 Additional details and impacted files @@ Coverage Diff @@
## main #1770 +/- ##
==========================================
+ Coverage 83.73% 83.87% +0.13%
==========================================
Files 136 136
Lines 9040 9041 +1
==========================================
+ Hits 7570 7583 +13
+ Misses 1470 1458 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
|
@JoanFM I've added an initial implementation of the change to add a field description for attribute of Text document. Would love to hear your thoughts and more changes that are needed. Can the example attribute from Field have a multi-line example? Since for bytes I want to provide one of video or audio bytes which needs a multiple line example |
Sorry, something went wrong.
|
Hello @punndcoder28 , Thanks for the contribution. However, we would need you to sign off the commit so that we can incorporate your improvements. |
Sorry, something went wrong.
|
Sorry for that. The commits should be signed off now |
Sorry, something went wrong.
|
@JoanFM What is the correct github flow? Should I rebase and keep my commits for a PR to a single commit? Or each change should be a different commit? |
Sorry, something went wrong.
As you want, eventually all the commits will be squashed into a single one, so your choice |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for the PR! :)
Sorry, something went wrong.
There was a problem hiding this comment.
A minor change
Sorry, something went wrong.
| ) | ||
| embedding: Optional[AnyEmbedding] = Field( | ||
| description='Store an embedding: a vector representation of the text', | ||
| example='''[[1, 1, 1], [1, 0, 1], [0, 0, 1]]''', |
There was a problem hiding this comment.
better have a single vector in the example
Sorry, something went wrong.
|
To resolve the conflicts, make sure to add None as the default value for the Optional fields. |
Sorry, something went wrong.
|
Also, the embedding example can be a list and should not be actually a text |
Sorry, something went wrong.
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
| Back | FazBrowse Home | New Git URL |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.