docs: adding field descriptions to predefined audio document - #1774
Merged
JoanFM merged 1 commit intoSep 14, 2023
Merged
Conversation
punndcoder28
force-pushed
the
docs_adding_field_description_audio_document
branch
from
106b51c to
be3e2ee
Compare
September 5, 2023 17:18
punndcoder28
commented
Sep 5, 2023
Comment thread
docarray/documents/audio.py
punndcoder28
commented
Sep 5, 2023
Comment thread
docarray/documents/audio.py
punndcoder28
marked this pull request as ready for review
September 5, 2023 17:20
Copy link
Copy Markdown
Codecov ReportPatch coverage: 100.00% and project coverage change: +0.13% 🎉 Additional details and impacted files @@ Coverage Diff @@
## main #1774 +/- ##
==========================================
+ Coverage 83.73% 83.87% +0.13%
==========================================
Files 136 136
Lines 9040 9041 +1
==========================================
+ Hits 7570 7583 +13
+ Misses 1470 1458 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
JoanFM
requested changes
Sep 6, 2023
Comment thread
docarray/documents/audio.py
Outdated
punndcoder28
force-pushed
the
docs_adding_field_description_audio_document
branch
from
be3e2ee to
8a7538d
Compare
September 6, 2023 17:59
punndcoder28
force-pushed
the
docs_adding_field_description_audio_document
branch
2 times, most recently
from
f47ba11 to
f9a1871
Compare
September 8, 2023 17:04
JoanFM
requested changes
Sep 14, 2023
Comment thread
docarray/documents/audio.py
Outdated
Comment thread
docarray/documents/audio.py
Outdated
Comment thread
docarray/documents/audio.py
Outdated
Comment thread
docarray/documents/audio.py
Outdated
Comment thread
docarray/documents/audio.py
Outdated
Copy link
Copy Markdown
Member
|
To resolve the conflicts, make sure to add None as the default value for the Optional fields. |
Sorry, something went wrong.
punndcoder28
force-pushed
the
docs_adding_field_description_audio_document
branch
2 times, most recently
from
bd495f4 to
ad71930
Compare
September 14, 2023 16:51
Copy link
Copy Markdown
Contributor
Author
|
Fixed the typo and removed '''...''' wherever it was not needed |
Sorry, something went wrong.
JoanFM
requested changes
Sep 14, 2023
Comment thread
docarray/documents/audio.py
Outdated
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
punndcoder28
force-pushed
the
docs_adding_field_description_audio_document
branch
from
ad71930 to
c3097df
Compare
September 14, 2023 17:32
JoanFM
approved these changes
Sep 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.