docs: adding field descriptions to predefined video document - #1775
Merged
JoanFM merged 2 commits intoSep 15, 2023
Merged
Conversation
punndcoder28
force-pushed
the
docs_adding_field_description_video_document
branch
from
eff956a to
c3d4930
Compare
September 5, 2023 17:52
punndcoder28
commented
Sep 5, 2023
Comment thread
docarray/documents/video.py
Outdated
punndcoder28
commented
Sep 5, 2023
Comment thread
docarray/documents/video.py
Outdated
punndcoder28
commented
Sep 5, 2023
Comment thread
docarray/documents/video.py
punndcoder28
marked this pull request as ready for review
September 5, 2023 17:54
Copy link
Copy Markdown
Codecov ReportPatch coverage: 100.00% and project coverage change: -3.66% ⚠️ Additional details and impacted files @@ Coverage Diff @@
## main #1775 +/- ##
==========================================
- Coverage 83.73% 80.08% -3.66%
==========================================
Files 136 136
Lines 9040 9044 +4
==========================================
- Hits 7570 7243 -327
- Misses 1470 1801 +331
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
samsja
reviewed
Sep 6, 2023
Comment thread
docarray/documents/video.py
Outdated
samsja
reviewed
Sep 6, 2023
Comment thread
docarray/documents/video.py
Outdated
samsja
reviewed
Sep 6, 2023
Comment thread
docarray/documents/video.py
Outdated
samsja
reviewed
Sep 6, 2023
Comment thread
docarray/documents/video.py
Outdated
JoanFM
requested changes
Sep 6, 2023
Comment thread
docarray/documents/video.py
Outdated
punndcoder28
force-pushed
the
docs_adding_field_description_video_document
branch
from
c3d4930 to
364359e
Compare
September 6, 2023 18:08
punndcoder28
force-pushed
the
docs_adding_field_description_video_document
branch
from
364359e to
95ba53e
Compare
September 6, 2023 18:12
JoanFM
requested changes
Sep 14, 2023
Comment thread
docarray/documents/video.py
Outdated
Copy link
Copy Markdown
Member
|
To resolve the conflicts, make sure to add None as the default value for the Optional fields. |
Sorry, something went wrong.
punndcoder28
force-pushed
the
docs_adding_field_description_video_document
branch
from
95ba53e to
f2b3040
Compare
September 14, 2023 16:56
JoanFM
requested changes
Sep 14, 2023
Comment thread
docarray/documents/video.py
Outdated
Comment thread
docarray/documents/video.py
Outdated
Signed-off-by: punndcoder28 <puneethk.2899@gmail.com>
punndcoder28
force-pushed
the
docs_adding_field_description_video_document
branch
from
f2b3040 to
e981291
Compare
September 14, 2023 17:34
JoanFM
requested changes
Sep 14, 2023
Comment thread
docarray/documents/video.py
Outdated
JoanFM
requested changes
Sep 15, 2023
Comment thread
docarray/documents/video.py
Outdated
Signed-off-by: Joan Fontanals <jfontanalsmartinez@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.